[tor-bugs] #27325 [Core Tor/Tor]: Rework NETINFO cell parsing and generation with trunnel

[Tor Bug Tracker & Wiki]

#27325: Rework NETINFO cell parsing and generation with trunnel
-------------------------+-------------------------------------------------
     Reporter:  rl1987   |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: unspecified
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  trunnel wireformat heartbleed-
     Severity:  Normal   |  safety security parsing
Actual Points:           |  Parent ID:  #27143
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 In `channel_tls_process_netinfo_cell()` we have:

 {{{
 1720   /* Decode the cell. */
 1721   timestamp = ntohl(get_uint32(cell->payload));
 1722   if (labs(now - chan->conn->handshake_state->sent_versions_at) <
 180) {
 1723     apparent_skew = now - timestamp;
 1724   }
 1725
 1726   my_addr_type = (uint8_t) cell->payload[4];
 1727   my_addr_len = (uint8_t) cell->payload[5];
 1728   my_addr_ptr = (uint8_t*) cell->payload + 6;
 1729   end = cell->payload + CELL_PAYLOAD_SIZE;
 1730   cp = cell->payload + 6 + my_addr_len;
 }}}

 and in `connection_or_send_netinfo()` we write the cell to connection
 buffer. Trunnel should be used.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27325>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online