[tor-bugs] #23818 [Core Tor/Tor]: Make v3 single onion services retry failed connections with a 3-hop path

[Tor Bug Tracker & Wiki]

#23818: Make v3 single onion services retry failed connections with a 3-hop path
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by neel):

 I merged the two branches for #23588 and #23576 here:
 https://github.com/neelchauhan/tor/tree/v3_sos

 However, `make test-network-all` tests involving v3 onion services fail:

 {{{
 neel at megora:~/Code/Tor/tor % make test-network-all
 mkdir -p ./test_network_log
 ping6 ::1 or ping ::1 succeeded, running IPv6 flavors: bridges+ipv6-min
 ipv6-exit-min hs-v23-ipv6-md  single-onion-ipv6-md.
 tor-stable not found, skipping mixed flavors: mixed+hs-v23.
 SKIP: mixed+hs-v23
 PASS: basic-min
 Detail: chutney/tools/warnings.sh
 /usr/home/neel/Code/Tor/chutney/net/nodes.1535244496
 Warning: Rejected vote from 127.0.0.1 ("Duplicate discarded"). Number: 1
 PASS: bridges-min
 PASS: hs-v2-min
 FAIL: hs-v3-min
 FAIL: single-onion-v23
 Detail: chutney/tools/warnings.sh
 /usr/home/neel/Code/Tor/chutney/net/nodes.1535244735
 Warning: Rejected vote from 127.0.0.1 ("Duplicate discarded"). Number: 2
 PASS: bridges+ipv6-min
 PASS: ipv6-exit-min
 FAIL: hs-v23-ipv6-md
 PASS: single-onion-ipv6-md
 Log and result files are available in ./test_network_log.
 *** Error code 1

 Stop.
 make: stopped in /usr/home/neel/Code/Tor/tor
 neel at megora:~/Code/Tor/tor %
 }}}

 It seems teor's branch for #23576 fails `make test-network-all` also.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23818#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online