[tor-bugs] #27236 [Core Tor/Tor]: When checking usable exit descriptors, always check exit policies

[Tor Bug Tracker & Wiki]

#27236: When checking usable exit descriptors, always check exit policies
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  reopened
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.6.3-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  034-must, 035-must, regression,      |  Actual Points:
  tor-bridge 034-backport                        |
Parent ID:  #27080                               |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  closed => reopened
 * reviewer:   => nickm
 * resolution:  fixed =>


Comment:

 I put the exit policy check in the wrong place, which made all exits
 require descriptors to be usable. Requiring descriptors for all exits
 skips the check that makes sure directories aren't trickling exits.

 Unfortunately, this improved fix does not fix #27080. I think we might
 need to fix more of the #27080 children.

 See my branch bug27236-034-fixup, which merges cleanly to master.

 CI:
 * https://travis-ci.org/teor2345/tor/builds/419930759
 * https://ci.appveyor.com/project/teor2345/tor/build/1.0.95 (for the
 master merge, because appveyor seems to have skipped bug27236-034-fixup)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27236#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online