[tor-bugs] #26896 [Core Tor/Tor]: Duplicate call to connection_mark_for_close

[Tor Bug Tracker & Wiki]

#26896: Duplicate call to connection_mark_for_close
------------------------------------------+--------------------------------
 Reporter:  toralf                        |          Owner:  nickm
     Type:  defect                        |         Status:  accepted
 Priority:  Medium                        |      Milestone:  Tor:
                                          |  0.3.4.x-final
Component:  Core Tor/Tor                  |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  034-must? regression? crash?  |  Actual Points:
Parent ID:                                |         Points:
 Reviewer:                                |        Sponsor:
------------------------------------------+--------------------------------
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


Comment:

 Okay -- this looks like a directory connection that got closed in main.c
 because it was stalled for a while, and then soon after we call
 connection_finished_flushing() on it because its linked connection just
 pulled some data from it anyway.

 The fact that this turned up in 0.3.4 is probably a side-effect of the
 mainloop refactoring.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26896#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online