[tor-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 20 12:59:33 UTC 2018


#25696: Design of alpha onboarding for Tor Browser for Android
-------------------------------------------------+-------------------------
 Reporter:  isabela                              |          Owner:
                                                 |  antonela
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201808R                          |
Parent ID:  #26531                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by igt0):

 Can you verify if your local branch has the following file:

 {{{./mobile/android/branding/torbrowser/res/drawable-
 nodpi/home_tab_menu_strip_tor.9.png}}} ?

 Looks like gradle was not able to find it. (I am seeing it in the patch)

 Replying to [comment:38 gk]:
 > So, the packaging step breaks for me with the patch. I wonder whether I
 am doing something wrong. I used sisbell's setup and am building .apk's
 for a while now but with your patch applied (I used `bug_25696_test` in my
 public tor-browser repo) I get:
 > {{{
 > 25:32.96 Processing annotations...
 > 25:33.81 Annotation processing complete in 851ms
 > 25:33.86
 :geckoview:processOfficialWithoutGeckoBinariesNoMinApiDebugResources
 > 25:33.86
 :app:processOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResources
 > 25:33.90
 :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugKotlin
 > 25:33.91
 :geckoview:generateOfficialWithoutGeckoBinariesNoMinApiDebugSources
 > 25:33.91
 :geckoview:javaPreCompileOfficialWithoutGeckoBinariesNoMinApiDebug
 > 25:34.51
 :geckoview:compileOfficialWithoutGeckoBinariesNoMinApiDebugJavaWithJavac/var/tmp/build
 /firefox-
 9c58e200f6eb/mobile/android/app/src/main/res/layout/firstrun_animation_container.xml:24:59-92:
 AAPT: No resource found that matches the given name (at 'strip' with value
 '@drawable/home_tab_menu_strip_tor').
 > 25:34.51
 > 25:34.51 /var/tmp/build/firefox-9c58e200f6eb/obj-arm-linux-
 androideabi/gradle/build/mobile/android/app/intermediates/res/merged/officialWithoutGeckoBinariesNoMinApiPhoton/debug/layout/firstrun_animation_container.xml:19:
 error: Error: No resource found that matches the given name (at 'strip'
 with value '@drawable/home_tab_menu_strip_tor').
 > 25:34.51
 > 25:34.51
 > 25:34.58 Failed to execute aapt
 > 25:34.58 com.android.ide.common.process.ProcessException: Failed to
 execute aapt
 > 25:34.58      at
 com.android.builder.core.AndroidBuilder.processResources(AndroidBuilder.java:796)
 > 25:34.58      at
 com.android.build.gradle.tasks.ProcessAndroidResources.invokeAaptForSplit(ProcessAndroidResources.java:551)
 > 25:34.58      at
 com.android.build.gradle.tasks.ProcessAndroidResources.doFullTaskAction(ProcessAndroidResources.java:285)
 > 25:34.58      at
 com.android.build.gradle.internal.tasks.IncrementalTask.taskAction(IncrementalTask.java:109)
 > 25:34.58      at sun.reflect.GeneratedMethodAccessor221.invoke(Unknown
 Source)
 > 25:34.58      at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 > 25:34.58      at java.lang.reflect.Method.invoke(Method.java:498)
 > 25:34.58      at
 org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
 > 25:34.58      at
 org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$IncrementalTaskAction.doExecute(DefaultTaskClassInfoStore.java:173)
 > 25:34.58      at
 org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
 > 25:34.59      at
 org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:121)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:122)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:111)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:92)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:70)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:63)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:52)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
 > 25:34.59      at
 org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
 > 25:34.59      at
 org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:248)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197)
 > 25:34.59      at
 org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107)
 > 25:34.59      at
 org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:241)
 > 25:34.59      at
 org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:230)
 > 25:34.59      at
 org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:124)
 > 25:34.59      at
 org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:80)
 > 25:34.60      at
 org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:105)
 > 25:34.60      at
 org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:99)
 > 25:34.60      at
 org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:625)
 > 25:34.60      at
 org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:580)
 > 25:34.60      at
 org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:99)
 > 25:34.60      at
 org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
 > 25:34.60      at
 org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
 > 25:34.60      at
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
 > 25:34.60      at
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
 > 25:34.60      at
 org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
 > 25:34.60      at java.lang.Thread.run(Thread.java:748)
 > }}}
 > How am I supposed to package the code (I am just running `./mach
 package`)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25696#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list