[tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

[Tor Bug Tracker & Wiki]

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * cc: nickm (added)
 * status:  needs_revision => merge_ready


Comment:

 I'd like to defer this patch until #27080 is fixed, or until 0.3.6. It's
 not an essential feature, and changes to this code have been risky in the
 past.

 nickm, what do you think?

 (If we do want it in 0.3.5, let's make sure test-network-all passes on a
 few machines.)

 I am also concerned about merging this feature without:
 * unit tests (#27086),
 * the 3-hop fallback for single onion services (#23818), and
 * the corresponding service-side IPv6 code (#23576 and #24193).

 We shouldn't hold it back forever, but if we wait until the next release,
 some of these related tasks should get done in that release.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:52>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online