[tor-bugs] #21530 [Core Tor/Tor]: Make ExitRelay 0 the default when there is no exit policy

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 20 03:50:53 UTC 2018


#21530: Make ExitRelay 0 the default when there is no exit policy
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-exit tor-relay configuration     |  Actual Points:
  usability expectations                         |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:2 neel]:
 > Like with many other bugs, I am interested in taking on this.
 >
 > I have a few questions:
 >
 > 1. Should I make `ExitRelay` a `bool` and make its default value `0`, or
 keep it an `autobool` and make it where the default value is based on
 whether `ExitPolicy` lines exist?

 You need to keep it an autobool, because changing it to a bool would break
 existing torrcs.

 > 2. If `ExitRelay` is `1`, and there is no exit policy line, should I act
 as if `ExitRelay` is `0`?

 No, you should log a warning and exit.

 > 3. If Question 2 is yes, can I implement a setting called
 `DefaultExitPolicy` with the default exit policy (that we normally have if
 we say we're an exit but don't have any specific exit policy) like we do
 with `ReducedExitPolicy`?

 The default exit policy is the default when ExitRelay is 1.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21530#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list