[tor-bugs] #27185 [Core Tor/Tor]: test/test.c and lround() prototype

[Tor Bug Tracker & Wiki]

#27185: test/test.c and lround() prototype
-------------------------------------------------+-------------------------
 Reporter:  gvanem                               |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.4.6-rc
 Severity:  Minor                                |     Resolution:
 Keywords:  clang-cl warning regression?         |  Actual Points:
  windows fast-fix 029-backport 032-backport     |
  033-backport 034-backport                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * owner:  (none) => teor
 * keywords:  clang-cl warning regression? windows =>
     clang-cl warning regression? windows fast-fix 029-backport
     032-backport 033-backport 034-backport
 * status:  needs_information => assigned


Comment:

 Ok, so the suggested patch is to use tor_lround() and tor_fabs() in the
 unit tests (and anywhere outside the module that defines them.)

 I think we have a script that does these kinds of checks. We should update
 it too.

 We should also backport this change to 0.2.9 and later.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27185#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online