[tor-bugs] #27190 [Core Tor/Tor]: disparate duplicate subproto handling in protover

[Tor Bug Tracker & Wiki]

#27190: disparate duplicate subproto handling in protover
----------------------------------------------+----------------------------
 Reporter:  cyberpunks                        |          Owner:  (none)
     Type:  defect                            |         Status:  new
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  unspecified
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  rust, 033-backport, 034-backport  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by cyberpunks):

 Replying to [comment:2 teor]:
 > No, duplicate subprotocol entries are allowed by the spec:

 That spec seems ambiguous and could be clarified in either direction.

 If it's clarified to forbid duplicates--it already says the entries should
 be sorted alphabetically--it would become simpler to also verify that
 there aren't any overlapping ranges, which the spec says shouldn't happen
 but the C implementation doesn't check for right now.

 Also, `make test-network-all` passes on branch protodupes1, at least.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27190#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online