[tor-bugs] #27164 [Core Tor/Tor]: rust protover accepts "Link=1-5-foo"
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Aug 17 13:29:55 UTC 2018
#27164: rust protover accepts "Link=1-5-foo"
----------------------------------------------+----------------------------
Reporter: cyberpunks | Owner: (none)
Type: defect | Status: closed
Priority: Medium | Milestone: Tor:
| 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.9
Severity: Normal | Resolution: fixed
Keywords: rust, 033-backport, 034-backport | Actual Points:
Parent ID: | Points:
Reviewer: teor | Sponsor:
----------------------------------------------+----------------------------
Changes (by nickm):
* status: needs_revision => closed
* resolution: => fixed
Comment:
Replying to [comment:5 cyberpunks]:
> Replying to [comment:3 teor]:
> > * code changes need a changes file that passes `make check-changes`
> > * (doc and comment changes don't get a changes file)
> Slight tangent, is that always true? Since
[https://gitweb.torproject.org/tor.git/tree/changes/doc26638?id=c8aecd14
doc26638] exists.
For comments, generally not, unless it's something massive and important.
For documentation, it's optional for small fixes and suggested for big
ones.
> Branch is rebased.
Thanks! Looks better now; merged to 0.3.3 and forward.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27164#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list