[tor-bugs] #27176 [Core Tor/Tor]: fix inaccurate rust docs

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 17 04:00:46 UTC 2018


#27176: fix inaccurate rust docs
--------------------------+------------------------------------
 Reporter:  cyberpunks    |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  rust,doc      |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------

Comment (by cyberpunks):

 Replying to [comment:2 teor]:
 > Can you explain why you deleted this line?

 The commit message explains
 > The function takes an already validated utf-8 string


 > As far as I'm aware, all rust strings must be utf-8.
 Which means this function cannot possibly fail from receiving a non-utf-8
 string, because a Rust string is what's being passed in, so it's already
 been validated when it was created.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27176#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list