[tor-bugs] #15518 [Core Tor/Tor]: Tor considers routers in the same IPv6 /16 to be "in the same subnet"

[Tor Bug Tracker & Wiki]

#15518: Tor considers routers in the same IPv6 /16 to be "in the same subnet"
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, path, path-bias, tor-client    |  Actual Points:
  easy                                           |
Parent ID:  #24393                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_revision
 * reviewer:   => teor


Comment:

 Thanks!

 Please fix the missing newline in the changes file, and add some unit
 tests for each of the new combinations:
 * IPv4 and IPv6
 * IPv6 and IPv4
 * IPv4 and IPv4-mapped-IPv6
 * IPv4-mapped-IPv6 and IPv4
 * IPv6 and IPv6

 If you'd like, you can remove the IPv4-mapped-IPv6 code, I don't think we
 actually use it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15518#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online