[tor-bugs] #27165 [Core Tor/Tor]: CID 1438153 unlikely overflow in predicted_ports_prediction_time_remaining()

[Tor Bug Tracker & Wiki]

#27165: CID 1438153 unlikely overflow in
predicted_ports_prediction_time_remaining()
--------------------------+----------------------------------
 Reporter:  catalyst      |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  coverity      |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 Made a quick fix to change all values we use in above function to
 `time_t`:

 https://github.com/torproject/tor/pull/277

 However further code tends that expects `int` from
 `predicted_ports_prediction_time_remaining()` got some casts now. I have
 some reservations if this is net positive for code base health.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27165#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online