[tor-bugs] #26972 [Core Tor/Tor]: Create make target to ensure that all Rust files have been formatted with rustfmt

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Aug 16 15:04:16 UTC 2018


#26972: Create make target to ensure that all Rust files have been formatted with
rustfmt
--------------------------+------------------------------------
 Reporter:  chelseakomlo  |          Owner:  teor
     Type:  enhancement   |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:  #24629        |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 Replying to [comment:24 cypherpunks3]:
 > Replying to [comment:22 teor]:
 > > There's a typo in CodingStandardsRust.md in your 132c7950dc. I did a
 fixup in da6054fe97
 >
 > Sorry about the rebase, thanks for fixing that. Of course trying to fix
 a typo had a typo...
 >
 > Replying to [comment:23 nickm]:
 >
 > Can't you just run `make check-rustfmt` to confirm that it recommends no
 further formatting changes?

 That's not the issue: the issue is to make sure that the commit contains
 _only_ formatting changes, to make sure that you didn't accidentally (or
 on purpose) mess with the code and commit any extra hidden surprises along
 with the formatting changesx.

 (That's not something I would expect you to do, but it's a good idea to be
 careful!)


 > Edit:
 [https://gitweb.torproject.org/tor.git/commit/?id=c8aecd14fecc55f5d8a48f793c24e3df68f1483c
 Oh wait, this is already merged.]

 Yeah -- after I wrote that, I went and checked it myself, but I'm hoping
 teor can doublecheck before we close.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26972#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list