[tor-bugs] #20874 [Core Tor/Tor]: ReachableAddresses adds an extra reject *:* on every SAVECONF

[Tor Bug Tracker & Wiki]

#20874: ReachableAddresses adds an extra reject *:* on every SAVECONF
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, torrc, saveconf,         |  Actual Points:
  configuration, annoyance, 035-triaged-         |
  in-20180711                                    |
Parent ID:                                       |         Points:  0.5
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_review => merge_ready


Comment:

 I am sorry for the delay here.

 Technically, you should not be appending the reject to the or and dir
 policy if the user only set one of those options and not the other.

 However, I think this is OK because it is simple and extra rejects at the
 end can't hurt in this case (unlike the situation we had before, where
 they were piling up in the actual config vars). Better simple than we miss
 an edge case, I think.

 Setting this to merge ready!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20874#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online