[tor-bugs] #26943 [Core Tor/Tor]: Privcount blinding and encryption: Safety fixes

[Tor Bug Tracker & Wiki]

#26943: Privcount blinding and encryption: Safety fixes
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust                     |
Parent ID:  #25669                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 I've done this as the middle part of my branch `ticket26939_26943_26940`;
 PR at https://github.com/nmathewson/privcount_shamir/pull/3 .  All of the
 unwrap() and assert! calls are now confined to the tests.

 This makes a lot more things return a Result than did before, but thanks
 to the ? operator, the code is fairly clean.

 Also, it is really cool that `Result<Vec<X>,Y>` implements
 `FromIterator<Result<X,Y>>`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26943#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online