[tor-bugs] #26973 [Core Tor/Tor]: Privcount blinding and encryption: add rustfmt CI check

[Tor Bug Tracker & Wiki]

#26973: Privcount blinding and encryption: add rustfmt CI check
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  privcount, 035-roadmap-master, 035   |  Actual Points:
  -triaged-in-20180711, rust                     |
Parent ID:  #25669                               |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm


Comment:

 Please see my branch ticket26973 in
 https://github.com/teor2345/privcount_shamir.git

 I disabled the rustfmt check because rust stable and beta disagree about
 some formatting. For example, see:
 https://travis-ci.org/teor2345/privcount_shamir/jobs/414426254#L1612

 The passing build is:
 https://travis-ci.org/teor2345/privcount_shamir/builds/414430540

 I still think we should merge this patch, because the current code passes
 the rustfmt check with rustfmt 0.99.1.

 Then we should defer the remaining tasks until Tor 0.3.6:
 * wait until rustfmt 0.99.1 hits stable
 * do a final format with rustfmt
 * activate the travis rustfmt check

 Assigning to nickm, because he probably wants to merge the rustfmt changes
 before starting other rust tickets.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26973#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online