[tor-bugs] #26972 [Core Tor/Tor]: Create CI task to ensure that all Rust files have been formatted with rustfmt

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Aug 7 23:51:25 UTC 2018


#26972: Create CI task to ensure that all Rust files have been formatted with
rustfmt
--------------------------+--------------------------------
 Reporter:  chelseakomlo  |          Owner:  teor
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  rust          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+--------------------------------

Comment (by teor):

 Replying to [comment:7 cypherpunks3]:
 > Replying to [comment:5 teor]:
 > > The travis build failed, due to old autoconf macros:
 > > https://travis-ci.org/teor2345/tor/builds/412925525
 > > Please fix
 >
 > Huh? According to the log, the source of the warning is a use of AC_WARN
 in configure.ac, and none of these patches added that, or even touched
 that file.

 Sorry, I didn't realise that CI was failing due to a bug in master.

 > It looks like a pre-existing condition. It seems to have already gotten
 fixed in
 [https://gitweb.torproject.org/tor.git/commit/?id=f90c0533777f2220cd6fb5ed07a5b63cd9c3e881
 f90c0533777f2220cd6fb5ed07a5b63cd9c3e881]. (Although not sure what #23878
 has to do with it.)

 I've pushed your rebased branch to my github, and I'll see if CI works
 this time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26972#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list