[tor-bugs] #26497 [Core Tor/Tor]: set CARGO_HOME correctly or stop using it

[Tor Bug Tracker & Wiki]

#26497: set CARGO_HOME correctly or stop using it
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, tor-ci, 035-removed-20180711,  |  Actual Points:
  035-roadmap-proposed                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by Hello71):

 Replying to [comment:5 catalyst]:
 > I'm leaning toward deleting all explicit settings of `CARGO_HOME`.
 >
 > Some old IRC discussion suggests that a difficulty with permissions on
 Jenkins was involved. Maybe our Jenkins configs don't allow `$HOME` to be
 writable by the builder? If so, `$HOME/.cargo` (the default) wouldn't
 work. I think that's not a strong reason to clutter other parts of our
 build system with it; we can adjust the Jenkins to set `CARGO_HOME`
 explicitly if needed.
 >
 > Also, leaving it as the default will let different invocations of cargo
 share the same cache, which helps with things like using the Travis CI
 cache (see #26952 and #24629).

 That's what I did in #26038 with https://cgit.alxu.ca/tor.git/commit/?h
 =misc-rust&id=b75f98ee0d0420ab608b7ae7b1cef21e47c7eea3. I'm still not sure
 what I meant by "not a no-op, fixes out-of-source builds" though. Someone
 should test if that actually does anything. (I guess I should.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26497#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online