[tor-bugs] #24629 [Core Tor/Tor]: Activate osx builds on travis, at low priority

[Tor Bug Tracker & Wiki]

#24629: Activate osx builds on travis, at low priority
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-    |  Actual Points:
  assigned, 034-triage-20180328,                 |
  034-removed-20180328, 034-backport,            |
  035-removed-20180711, fast-fix                 |
Parent ID:                                       |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 I like a lot of these changes. Simplifying stuff so we don't have to list
 every matrix row explicitly seems quite helpful. I think there are a few
 minor changes remaining.

 I think `$TRAVIS_BUILD_DIR/target` isn't the right directory for caching
 Rust build output; it's probably more correct to use
 `$TRAVIS_BUILD_DIR/src/rust/target`, because that's where we point
 `CARGO_TARGET_DIR` in all our cargo invocations.

 Also we should probably stop setting `CARGO_HOME` explicitly so more stuff
 ends up in `$HOME/.cargo` to cache. (see #26497; we could put the fix in
 that ticket, or maybe do it in this branch but make that ticket a child of
 this one)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24629#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online