[tor-bugs] #25928 [Core Tor/Tor]: Single DA in sandbox vs. PDS_ALLOW_SELF flag

[Tor Bug Tracker & Wiki]

#25928: Single DA in sandbox vs. PDS_ALLOW_SELF flag
---------------------------------------+----------------------------------
 Reporter:  somlo                      |          Owner:  (none)
     Type:  defect                     |         Status:  new
 Priority:  Medium                     |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-dirauth, test-network  |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+----------------------------------

Comment (by somlo):

 I tried something like this:
 {{{
 diff --git a/src/or/routerlist.c b/src/or/routerlist.c
 index 1bfbd9f67..0d75eb0f5 100644
 --- a/src/or/routerlist.c
 +++ b/src/or/routerlist.c
 @@ -1761,6 +1761,8 @@ trusteddirserver_get_by_v3_auth_digest, (const char
 *digest))
  const routerstatus_t *
  router_pick_trusteddirserver(dirinfo_type_t type, int flags)
  {
 +  if (smartlist_len(trusted_dir_servers) <= 1)
 +    flags |= PDS_ALLOW_SELF;
    return router_pick_dirserver_generic(trusted_dir_servers, type, flags);
  }

 }}}
 ... and it seems to work so far. Is this overly simplistic? (I am, after
 all, unfamiliar with the code base... :) )

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25928#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online