[tor-bugs] #19429 [Core Tor/Tor]: Clean up our OpenSSL 1.1 support.

[Tor Bug Tracker & Wiki]

#19429: Clean up our OpenSSL 1.1 support.
-------------------------------------------------+-------------------------
 Reporter:  yawning                              |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.8.4-rc
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-crypto openssl refactor future-  |  Actual Points:
  proof                                          |
Parent ID:                                       |         Points:  3
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by catalyst):

 I get
 {{{
 src/common/tortls.c:64:0: error: "X509_get_notBefore" redefined [-Werror]
  #define X509_get_notBefore(cert) \
  ^
 In file included from /home/tlyu/ssl/include/openssl/ssl.h:50:0,
                  from src/common/tortls.c:41:
 /home/tlyu/ssl/include/openssl/x509.h:635:0: note: this is the location of
 the previous definition
  #  define X509_get_notBefore X509_getm_notBefore
  ^
 src/common/tortls.c:66:0: error: "X509_get_notAfter" redefined [-Werror]
  #define X509_get_notAfter(cert) \
  ^
 In file included from /home/tlyu/ssl/include/openssl/ssl.h:50:0,
                  from src/common/tortls.c:41:
 /home/tlyu/ssl/include/openssl/x509.h:636:0: note: this is the location of
 the previous definition
  #  define X509_get_notAfter X509_getm_notAfter
  ^
 }}}
 with a freshly built openssl-1.1.0h and default options (except for
 `--prefix`).  I'll check against a `--no-deprecated` build to see if
 there's any difference.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19429#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online