[tor-bugs] #25741 [Applications/Tor Browser]: Create tor-browser for mobile branch based on mozilla-central

[Tor Bug Tracker & Wiki]

#25741: Create tor-browser for mobile branch based on mozilla-central
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  sysrqb
     Type:  defect                    |         Status:  assigned
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201804      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 Okay, nearly done.

 Notes: during the rebase I changed Orfox -> torbrowser, and I renamed
 .mozconfig-orfox -> .mozconfig-android.

 While I updated .mozconfig-android:
  1) I noticed BUILD_OFFICIAL is dead, I deleted this (maybe delete from
 other .mozconfig, too).
  2) Question: why do we set MOZILLA_OFFICIAL in .mozconfig?
  3) --disable-install-strip on mobile? What errors were seen before?

 For (2), to be precise, from what I see `mk_add_options
 MOZILLA_OFFICIAL=1` does not set `MOZILLA_OFFICIAL=1`. The in-tree
 mozconfigs use `export MOZILLA_OFFICIAL=1` and they have a comment "#
 Needed to enable breakpad in application.ini" dated in 2011. I confirmed
 changing `mk_add_options MOZILLA_OFFICIAL=1` to `export
 MOZILLA_OFFICIAL=1` does set `MOZILLA_OFFICIAL=1`.

 I'll research (3). The comment in .mozconfig-orfox says "== Known mobile
 build flag that causes errors", but I'd like having this documented so we
 know if/when this works.

 I'm running a few more builds for testing (and then I'll wait for #25543)

 Based on 61.0.a1
 Repo: ​https://git.torproject.org/user/sysrqb/tor-browser.git
 Branch: bug25741_orfox_patches

 Based on #25543 (60.0b15) + cherry-pick from bug25741_orfox_patches
 Repo: ​https://git.torproject.org/user/sysrqb/tor-browser.git
 Branch: bug25741_orfox_patches_beta_plus_25543+7

 Testing a build from bug25741_orfox_patches_beta_plus_25543+7 confirms
 Necko connections do not bypass the proxy configured by pref. TBA should
 benefit from most of the proxy-bypass work done for desktop, so (as
 expected) we should concentrate on the java-based network connections.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25741#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online