[tor-bugs] #25543 [Applications/Tor Browser]: Rebase Tor Browser patches for ESR60
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Apr 26 18:56:14 UTC 2018
#25543: Rebase Tor Browser patches for ESR60
--------------------------------------+---------------------------------
Reporter: gk | Owner: arthuredelstein
Type: task | Status: assigned
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201804 | Actual Points:
Parent ID: #25741 | Points:
Reviewer: | Sponsor:
--------------------------------------+---------------------------------
Comment (by arthuredelstein):
Replying to [comment:13 mcs]:
> I attached a zip archive that contains a few more fixup patches.
Thanks for these -- I have added them to
https://github.com/arthuredelstein/tor-browser/commits/25543+7 (HEAD is
now fe38c8a83d8e90a99f6d04fb19a1dc085a19a766).
> There are probably more places in the Tor Browser patches where we need
to remove the JS version from the MIME type when referencing from an XHTML
file or HTML file (see `0001-fixup-Bug-16940-After-update-load-local-
change-notes.patch` within the zip archive).
I did a search to find any examples of "version=" and found them in the
following files:
{{{
docshell/test/test_tor_bug16620.html
docshell/test/tor_bug16620.html
docshell/test/tor_bug16620_form.html
dom/events/test/test_tor_bug15646.html
tbb-tests/test_tor_bug1517.html
tbb-tests/test_tor_bug23104.html
tbb-tests/test_tor_bug2875.html
}}}
These are all tests we have added, and it seems that the scripts still
run, so I'm inclined not to patch them, although it would do no harm to do
so.
> Also, Kathy and I finished our initial rebasing of the updater patches
and are in the process of testing them. I assume you would rather wait and
receive tested patches, but let us know if you would rather have them
sooner (we will probably not finish the updater testing until next week).
Waiting for your tests sounds good to me. Thank you!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25543#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list