[tor-bugs] #25903 [Core Tor/Tor]: Add OVERHEAD and DELIVERED fields to CIRC_BW events

[Tor Bug Tracker & Wiki]

#25903: Add OVERHEAD and DELIVERED fields to CIRC_BW events
----------------------------------+------------------------------
 Reporter:  mikeperry             |          Owner:  (none)
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  034-roadmap-proposed  |  Actual Points:
Parent ID:  #25546                |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Third time's a charm:
 ​​https://oniongit.eu/mikeperry/tor/commits/bug25903_v3 for code changes.
 ​​https://gitweb.torproject.org/user/mikeperry/torspec.git/log/?h=bug25903_v3
 for spec changes.

 This version counts any relay cell the client decides to write as valid
 delivered written data. For received data, it counts relay cells as valid
 delivered data if they do not trigger an error condition in the code that
 handles them.

 I've been testing this with https://github.com/mikeperry-tor/vanguards/ on
 client and service side and have gotten it down to no false positives on
 service side. On client side, if the client closes the connection while
 data is in flight, then that stream id will be unknown, and those packets
 will be dropped data (need #25573 for that).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25903#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online