[tor-bugs] #25903 [Core Tor/Tor]: Add PACKAGED and DELIVERED fields to CIRC_BW events

[Tor Bug Tracker & Wiki]

#25903: Add PACKAGED and DELIVERED fields to CIRC_BW events
----------------------------------+------------------------------
 Reporter:  mikeperry             |          Owner:  (none)
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  034-roadmap-proposed  |  Actual Points:
Parent ID:  #25546                |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Second try:

 ​https://oniongit.eu/mikeperry/tor/commits/bug25903_v2 for code changes.
 ​https://gitweb.torproject.org/user/mikeperry/torspec.git/log/?h=bug25903_v2
 for spec changes.

 In those two, I add DELIVERED and OVERHEAD. DELIVERED is the same as
 before (sum of RELAY_COMMAND_DATA rh.length fields). OVERHEAD is the sum
 of the extra unused space in RELAY_COMMAND_DATA fields.

 The idea is that the original READ and WRITTEN fields can be used to count
 all of the cell data sent on the circuit. Then you can add
 DELIVERED+OVERHEAD, and subtract that from the original CIRC_BW fields and
 get the count of bytes consumed due to all non-application cells. This
 should be an approximation of the dropped cell data on the circuit (not
 counting legit non-application data like SENDME cells, HS state machine
 cells).

 The plan is to use this to set limits in the vanguards script on the ratio
 of RELAY_COMMAND_DATA to other stuff on the circuit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25903#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online