[tor-bugs] #25803 [Core Tor/Tor]: Infinite restart loop when daemon crashes

[Tor Bug Tracker & Wiki]

#25803: Infinite restart loop when daemon crashes
----------------------------------------------+----------------------------
 Reporter:  tiejohg2sahth                     |          Owner:  (none)
     Type:  defect                            |         Status:  new
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  unspecified
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  systemd, tor-relay, security-low  |  Actual Points:
Parent ID:                                    |         Points:  0.1
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------

Comment (by tiejohg2sahth):

 Replying to [comment:4 arma]:
 > I haven't learned much about systemd yet, so please ignore this if you
 have a better handle on things, but: in the past one of Tor's transient
 failure modes was that the system would start it before the system had set
 up its IP addresses (especially true with the world of ipv6), or before
 the system had set up its network interfaces, and if it just gave up right
 then, the system Tor would stay down. So retrying some times, especially
 at first boot, used to make sense.

 I am in no way a systemd expert either, but usually adding theses 2 lines
 in the service file ensures the network is ready when the service starts:
 {{{
 After=network-online.target
 Wants=network-online.target
 }}}
 See: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

 The goal of a modern init system is precisely to handle this cases
 properly and remove the burden of having to manually do retry loops.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25803#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online