[tor-bugs] #25803 [Core Tor/Tor]: Infinite restart loop when daemon crashes

[Tor Bug Tracker & Wiki]

#25803: Infinite restart loop when daemon crashes
----------------------------------------------+----------------------------
 Reporter:  tiejohg2sahth                     |          Owner:  (none)
     Type:  defect                            |         Status:  new
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  unspecified
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  systemd, tor-relay, security-low  |  Actual Points:
Parent ID:                                    |         Points:  0.1
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by teor):

 * keywords:  systemd? => systemd, tor-relay, security-low
 * points:   => 0.1


Comment:

 I think we might want to use Restart=on-success instead.

 It doesn't make sense to restart in any of the listed failure modes:
 https://www.freedesktop.org/software/systemd/man/systemd.service.html

 Would you like to submit a patch for this?

 The relevant file is:
 https://gitweb.torproject.org/tor.git/tree/contrib/dist/tor.service.in

 You may also need to submit separate bugs to the Debian and Ubuntu bug
 trackers to get them fixed.

 I am marking this as security-low, because it could make exploitation
 easier.
 But, it also makes maintaining availability harder, so it weakens our DoS
 resistance.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25803#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online