[tor-bugs] #23693 [Core Tor/Tor]: 0.3.1.7: Assertion threadpool failed in cpuworker_queue_work

[Tor Bug Tracker & Wiki]

#23693: 0.3.1.7: Assertion threadpool failed in cpuworker_queue_work
-------------------------------------------------+-------------------------
 Reporter:  alif                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.9
 Severity:  Normal                               |     Resolution:
 Keywords:  prop286, 034-triage-20180328,        |  Actual Points:
  034-must crash 033-backport 032-backport       |
  031-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Hmm, I took the torrc from comment:28 to test the patch. The original
 assert seems to be fixed but now it crashes on a different place:
 {{{
 Apr 17 14:01:00.000 [notice] Bootstrapped 0%: Starting
 Apr 17 14:01:00.000 [notice] Starting with guard context "default"
 Apr 17 14:01:00.000 [err] tor_assertion_failed_(): Bug:
 src/or/router.c:142: dup_onion_keys: Assertion onionkey failed; aborting.
 (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug: Assertion onionkey failed in dup_onion_keys
 at src/or/router.c:142. Stack trace: (on Tor 0.3.1.10-dev
 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(log_backtrace+0x43)
 [0x557795fffab3] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:
 ./src/or/tor(tor_assertion_failed_+0x8d) [0x557796018add] (on Tor
 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(dup_onion_keys+0x10f)
 [0x557795f22a9f] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:
 ./src/or/tor(server_onion_keys_new+0x41) [0x557795ef2f91] (on Tor
 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(+0x1283b7)
 [0x557795fb93b7] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(threadpool_new+0x18b)
 [0x55779601f91b] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(cpu_init+0xad)
 [0x557795fb97dd] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(do_main_loop+0x15d)
 [0x557795ee0d2d] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(tor_main+0xe25)
 [0x557795ee3b25] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(main+0x19)
 [0x557795edc729] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xe7) [0x7faf9e096a87] (on Tor
 0.3.1.10-dev 386f8016b7373bec)
 Apr 17 14:01:00.000 [err] Bug:     ./src/or/tor(_start+0x2a)
 [0x557795edc77a] (on Tor 0.3.1.10-dev 386f8016b7373bec)
 }}}

 I guess that when we are not in server mode, Tor won't create the onionkey
 in `init_keys()`... I wonder if we should try to fix these situations with
 patches like the one from comment:29, or we should just disallow having a
 DirPort without an ORPort and abort if such a configuration is seen. IIUC,
 we are planning to eventually deprecate DirPort anyhow and just use
 `BEGIN_DIR`, right?

 Here is the torrc:
 {{{
 DirPort 9030
 SocksPort 0
 Log notice stdout
 DataDirectory /tmp/tor
 RelayBandwidthRate 4 MBytes
 RelayBandwidthBurst 5 MBytes
 ExitRelay 0
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23693#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online