[tor-bugs] #25386 [Core Tor/Tor]: fix rust tests

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Apr 17 02:21:03 UTC 2018


#25386: fix rust tests
-------------------------------------------------+-------------------------
 Reporter:  Hello71                              |          Owner:  Hello71
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, tor-test, 033-backport,        |  Actual Points:
  review-group-34, 034-triage-20180328,          |
  034-included-20180401                          |
Parent ID:                                       |         Points:  3
 Reviewer:  isis                                 |        Sponsor:
                                                 |  SponsorQ
-------------------------------------------------+-------------------------

Comment (by Hello71):

 I have pushed to https://cgit.alxu.ca/tor.git/log/?h=meson an
 implementation of the shared library approach (along with a bunch of other
 crap that I'll have to separate out). This approach seems to be the most
 reliable and, with `-static-libasan`, hopefully fixes all issues with asan
 incompatibilities. remaining problems:

 1. still need to actually build a shared library, so either #23846 or
 switch to a better build system.

 2. rustdoc doesn't take `-Z sanitizer` (https://github.com/rust-
 lang/rust/issues/43031), but I think maybe we can hack around that by
 cleaning first and just accept that doctests won't have sanitizers for
 now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25386#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list