[tor-bugs] #25793 [Core Tor/Tor]: Refactor refactored token bucket API to be more generic

[Tor Bug Tracker & Wiki]

#25793: Refactor refactored token bucket API to be more generic
------------------------------+---------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  034-roadmap-subtask
Actual Points:                |  Parent ID:  #25373
       Points:                |   Reviewer:
      Sponsor:  Sponsor8-can  |
------------------------------+---------------------------------
 The #25766 work makes us have a clean token bucket API.  But that API
 isn't reusable yet.  Let's fix it so we can use it for all the other
 places in our code that we want a token bucket.

 The two main things to do here are:
  * decouple "read bucket" from "write bucket".
  * decouple "parameters" from "bucket value".
  * make time generic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25793>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online