[tor-bugs] #25705 [Core Tor/Tor]: Refactor circuit_build_failed to separate build vs path failures

[Tor Bug Tracker & Wiki]

#25705: Refactor circuit_build_failed to separate build vs path failures
--------------------------+------------------------------------
 Reporter:  mikeperry     |          Owner:  (none)
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #25546        |         Points:
 Reviewer:  asn           |        Sponsor:  SponsorV-can
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 I don't think arma's concern above was correct. I just tested mike's
 branch (and master) with an offline network and made sure that the
 `MAX_CIRCUIT_FAILURES` spinning protection kicks in. That happens because
 this ticket does not report failures only in the case of '''path selection
 failures'''. In the case of an offline network, the failures are not path
 selection related (they are circuit build related), so the failed circuits
 are counted correctly.

 I took a second look at Mike's patch and looks good to me. Marking this as
 `merge_ready`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25705#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online