[tor-bugs] #25760 [Core Tor/Tor]: Remove TestingEnableTbEmptyEvent if it is no longer used

[Tor Bug Tracker & Wiki]

#25760: Remove TestingEnableTbEmptyEvent if it is no longer used
------------------------------+---------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  034-roadmap-subtask
Actual Points:                |  Parent ID:  #25373
       Points:                |   Reviewer:
      Sponsor:  Sponsor8-can  |
------------------------------+---------------------------------
 The TestingEnableTbEmptyEvent logic uses a lot of code and complicates our
 token bucket refill logic.  If we need to keep it working, we can -- but
 it would be much simpler to remove it, if it is not in use.

 Is anybody still using it?  We seem to have added it in 0.2.5.2-alpha,
 back in 2013.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25760>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online