[tor-bugs] #24734 [Core Tor/Tor]: Remove the return value of fascist_firewall_choose_address_node()

[Tor Bug Tracker & Wiki]

#24734: Remove the return value of fascist_firewall_choose_address_node()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, tor-relay,                     |  Actual Points:
  034-triage-20180328, 034-removed-20180328      |
Parent ID:  #24403                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by neel):

 * status:  new => assigned
 * cc: neel@… (added)
 * owner:  (none) => neel


Comment:

 I am interested in taking this ticket.

 However, looking at the source code, I see
 `fascist_firewall_choose_address_node()` returns a
 `fascist_firewall_choose_address_base()`. Would it be okay to just call
 the latter from the former without a return value?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24734#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online