[tor-bugs] #25705 [Core Tor/Tor]: Refactor circuit_build_failed to separate build vs path failures

[Tor Bug Tracker & Wiki]

#25705: Refactor circuit_build_failed to separate build vs path failures
--------------------------+------------------------------
 Reporter:  mikeperry     |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #25546        |         Points:
 Reviewer:                |        Sponsor:  SponsorV-can
--------------------------+------------------------------

Comment (by mikeperry):

 How about a log_fn_ratelim(LOG_NOTICE/LOG_WARN) here instead of the info
 log, then? This is not something that should happen unless the user is
 doing something crazy in torrc, or there is another bug (such as not
 having enough mds and never getting more). In each case they/we want to
 know that it happened, and I also think that not giving up in these cases
 is a good move, even if it costs a bit of spinning.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25705#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online