[tor-bugs] #25610 [Core Tor/Tor]: module: Modularized directory authority subsystem

[Tor Bug Tracker & Wiki]

#25610: module: Modularized directory authority subsystem
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  modularization, 034-roadmap-         |  Actual Points:
  subtask, tor-dirauth, 034-triage-20180328,     |
  034-included-20180328                          |
Parent ID:  #25494                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 Replying to [comment:6 chelseakomlo]:
  > One note about heavy refactoring- having sufficient tests in place is
 really helpful before splitting apart large pieces of functionality and
 refactoring. As part of this plan, maybe add a goal to audit existing
 tests/write any more necessary tests ideally as one of the first steps to
 help when touching particularly old/convoluted parts of the code.

 Indeed. That part of the code does have many tests but not in majority I
 think. Fortunately, for now we are just moving code around, no code
 behavior change. And ideally we keep it that way for the most part. I
 expect that it won't be true for some parts as we are still discovering
 those tricky them. For sure at that point, testing is needed.

 However, being able to test the entry points to the dirauth subsystem when
 it is *disable* would be desirable so we make sure that tor still works
 properly. Again, we are lucky in some ways with this subsystem because
 most of the entry point are guarded with "Am I a dirauth" so this part we
 can hard assert that if the module is disabled, it can NOT send back true.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25610#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online