[tor-bugs] #25511 [Core Tor/Tor]: Expose TZ info on control port for better debugging of time errors

[Tor Bug Tracker & Wiki]

#25511: Expose TZ info on control port for better debugging of time errors
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  roadmap, controller, 034-roadmap-    |  Actual Points:
  master, 034-triage-20180328,                   |
  034-included-20180328, s8-errors               |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:24 mikeperry]:
 > Thank you neel! I really appreciate this. This was originally going to
 fall to me or catalyst. More time for vanguards now :)
 >
 > This looks good, but as a note, Tor Browser is going to have to remember
 not to overwrite the TZ environment variable before or while it launches
 Tor for current-time/local to not also be UTC. (This may mean saving the
 previous TZ value before we set it to UTC, and using that in the environ
 for tor).

 Tor currently logs in UTC when launched by Tor Browser. If we use the OS
 TZ variable, it will log every message in the local timezone, and some
 messages also contain UTC times. Does this cause issues with disk traces,
 or does TBB avoid leaving tor logs around? Do we want users posting logs
 in their local timezone to trac? (Some timezone offsets are quite unique.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25511#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online