[tor-bugs] #25705 [Core Tor/Tor]: Refactor circuit_build_failed to separate build vs path failures

[Tor Bug Tracker & Wiki]

#25705: Refactor circuit_build_failed to separate build vs path failures
--------------------------+------------------------------
 Reporter:  mikeperry     |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #25546        |         Points:
 Reviewer:                |        Sponsor:  SponsorV-can
--------------------------+------------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 I don't feel super strongly about the second commit. I threw it in as an
 afterthought so we could compare it against #25347. I guess I forgot to
 even check that it compiled :/

 I think we can drop it, subject to a plan to move to two guards. I do not
 think it is at all safe to stay with one guard *and* allow guards to be
 DoS'd to the point where client activity ceases. That is a clear
 confirmation signal that can be used to build a guard discovery attack.

 https://oniongit.eu/mikeperry/tor/commits/bug25705_v2 (just the first
 commit)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25705#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online