[tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Apr 3 23:26:01 UTC 2018


#25126: about:tor should work on small screens (mobile)
-------------------------------------------------+-------------------------
 Reporter:  igt0                                 |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201804  |  Actual Points:
Parent ID:  #24855                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 Thanks Kathy and mcs. Indeed I rebased with the wrong branch. The patch
 bellow fixes all the issues described by you.

    **bug 25126: Make about:tor layout responsive**
 https://github.com/igortoliveira/torbutton/commit/d12165d161817573e59ca0b6effa5d5e8d5cafe0

 Replying to [comment:11 mcs]:
 > Kathy and I reviewed the changes and tested them using a desktop
 browser. We like the use of flexbox layout (very nice), but we found a few
 things that we should be fixed:
 > * We could merge this now if it didn't depend on some earlier changes.
 It is also confusing that the patch "undoes" some earlier changes, so
 please make a new patch that does not depend on
 a35a746ca206706f4c5742d70bc90b649c1bfdf0 and
 40682676e33570d464534adc07bf94acb36a76fe.
 > * The class name `container` is very generic. Please replace it with a
 more specific name such as `torstatus-container`.
 > * Removing `.top` from `aboutTor.css` causes the "WARNING: this browser
 is out of date." text to no longer be centered.
 > * The fancy arrow that points to the toolbar item to encourage users to
 update their browser loses its horizontal tail when the browser window is
 at its default width. Somehow the div that has no id (that immediately
 follows the #torstatus div) is now wider than it used to be. This may be a
 consequence of the flexbox layout or just the adding of the .container
 div.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25126#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list