[tor-bugs] #25705 [Core Tor/Tor]: Refactor circuit_build_failed to separate build vs path failures

[Tor Bug Tracker & Wiki]

#25705: Refactor circuit_build_failed to separate build vs path failures
--------------------------+------------------------------
 Reporter:  mikeperry     |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #25546        |         Points:
 Reviewer:                |        Sponsor:  SponsorV-can
--------------------------+------------------------------
Changes (by mikeperry):

 * status:  new => needs_review


Comment:

 Ok, I made the smallest possible change here. I just moved the path length
 check up from the guard failure block to the beginning of the function.
 The only thing that wasn't build failure accounting or node/network
 blaming was the HS RP retry code, which I also moved up.

 I also removed the destroy check, as per #25347, as a separate commit. We
 can decide which one we like better. On the one hand, asn's branch has
 more checks and might be safer. On the other hand, this is a smaller
 change, and keeps everything related to counting circuit failures in the
 same place.

 mikeperry/bug25705

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25705#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online