[tor-bugs] #23676 [Core Tor/Tor]: kist on 0.3.2.1-alpha-dev beats its head against a wall trying to flush a conn that's closed

[Tor Bug Tracker & Wiki]

#23676: kist on 0.3.2.1-alpha-dev beats its head against a wall trying to flush a
conn that's closed
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  regression, cpu, tor-sched, 0.3.2.2  |  Actual Points:
  -alpha-must                                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 See branch: `bug23676_032_03`.

 Because we move the channel back to waiting_for_cells, we don't need to
 re-add it to the pending channels so I removed the offending commit that
 introduce `add_chan_to_readd_list()`.

 You'll also notice in the commit message and code that I explicitly state
 that there is probably a deeper problem with this flush_result = 0 and I
 want us to be aware and have a trace on why we did this fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23676#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online