[tor-bugs] #23100 [Core Tor/Tor]: Circuit Build Timeout needs to count hidden service circuits

[Tor Bug Tracker & Wiki]

#23100: Circuit Build Timeout needs to count hidden service circuits
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, path-bias, guard-discovery,  |  Actual Points:
  needs-proposal, mike-can, prop247, tor-guard   |
Parent ID:  #9001                                |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the patch! This seems important! A few comments:

 - I don't understand how the mods to
 `circuit_timeout_want_to_count_circ()` helps us achieve the goal of this
 ticket. It kinda seems like we are restricting that function even more
 (doc change implies that too), when we actually want it to be more
 accepting. I think a nice comment is required for people like me to
 understand how that function works wrt HS circs.

 - I also don't understand why the
 `circuit_build_times_decide_to_count_circ()` logic was moved from one
 function to another. I think we need some help here to understand, since
 I'm not familiar with the CBT system at all.

 - I think `circuit_get_cpath_len()` should be moded instead of adding
 another func `circuit_get_cpath_opened_len()`. We can add an arg
 `only_count_opened` which does that. I think that'd be cleaner.

 - `circuit_build_times_decide_to_count_circ()` is undocumented and I'd
 actually like to know what it does.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23100#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online