[tor-bugs] #23551 [Core Tor/Tor]: src/common/compress.c:576: tor_compress_process: Non-fatal assertion

[Tor Bug Tracker & Wiki]

#23551: src/common/compress.c:576: tor_compress_process: Non-fatal assertion
--------------------------------+------------------------------------
 Reporter:  cypherpunks         |          Owner:  ahf
     Type:  defect              |         Status:  merge_ready
 Priority:  High                |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor        |        Version:  Tor: 0.3.1.5-alpha
 Severity:  Normal              |     Resolution:
 Keywords:  0.3.2.2-alpha-must  |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  isis                |        Sponsor:
--------------------------------+------------------------------------
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:13 ahf]:
 > I have a proposed fix for this issue. It can be found in the following
 branches:
 >
 > - for tor.git's master branch:
 https://gitlab.com/ahf/tor/merge_requests/19
 > - for tor.git's maint-0.3.1 branch:
 https://gitlab.com/ahf/tor/merge_requests/20

 - `c2fac2c6` LGTM (yay test driven dev)
 - `44dc4b73` LGTM
 - `c3b7f9d7` LGTM
 - `a196fdb6` LGTM

 FWIW this didn't require any libzstd knowledge to review, so I feel
 comfortable that my assessment is correct. If someone else still wants to
 also review, though, please feel free.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23551#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online