[tor-bugs] #23662 [Core Tor/Tor]: prop224: Service edge-case where it re-uploads descriptor with same rev counter

[Tor Bug Tracker & Wiki]

#23662: prop224: Service edge-case where it re-uploads descriptor with same rev
counter
-----------------------------+------------------------------------
 Reporter:  asn              |          Owner:  (none)
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  new => needs_review


Comment:

 See branch: `ticket23662_032_01`

 First commit is a big refactoring of `connection_ap_expire_beginning()` so
 we can make sense out of it and introduce a function that checks if we
 should retry the connection on timeout.

 Second commit adds a callback in the HS subsystem for any directory
 connection linked to the AP one that has timed out so the retry can be
 handled properly.

 This whole thing might be over the top but if we think it is a good idea,
 lets put it back in `needs_revision` so I can add a unit test for
 `connection_ap_expire_beginning()` for which none exists right now. If
 that is too much for 032, I can try to do a minimal change but at the cost
 of technical debt of course :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23662#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online