[tor-bugs] #16678 [Applications/Tor Browser]: Enhance KeyboardEvent fingerprinting protection for unusual characters

[Tor Bug Tracker & Wiki]

#16678: Enhance KeyboardEvent fingerprinting protection for unusual characters
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  sysrqb
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-fingerprinting,                  |  Actual Points:
  TorBrowserTeam201709                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 After I read Arthur's comment on the github branch[0] I realized there's a
 bug in the patch. I pushed a fixup commit that corrects it[1].

 So it's in this ticket, the relevant part is:
 {{{
 Every call to KEY/SHIFT/ALTGR updates the mapping in all hashmaps,
 therefore
 calling both ALTGR and SHIFT for the same key results in the ALTGR state
 being
 overwritten. I'll leave these comments above and instead I'll create a
 fourth
 macro for ALTGRSHIFT that correctly inserts the key into the hashmaps.
 I'll
 then replace all occurrences of ALTGR()+SHIFT() with ALTGRSHIFT().
 }}}

 Commit 1e094349cd679d8592411d741512d71bc29185fc does this.

 [0] https://github.com/sysrqb/tor-
 browser/commit/bug16678_2#commitcomment-24566167
 [1] https://github.com/sysrqb/tor-
 browser/commit/1e094349cd679d8592411d741512d71bc29185fc

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16678#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online