[tor-bugs] #23663 [Applications/Tor Browser]: ESR52 codebase is incompatible with anything below Universal C Runtime (CRT) in Windows

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 26 18:57:09 UTC 2017


#23663: ESR52 codebase is incompatible with anything below Universal C Runtime
(CRT) in Windows
--------------------------------------+-----------------------------------
 Reporter:  cypherpunks               |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Major                     |     Resolution:
 Keywords:  tbb-security              |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------
Changes (by gk):

 * status:  new => needs_information


Comment:

 Replying to [comment:2 cypherpunks]:
 > Are you sure? Did you see what was removed in the last bug? Citing:
 > {{{
 > -    /* we use n - 1 here because if the buffer is not big enough, the
 MS
 > -     * runtime libraries don't add a terminating zero at the end. MSDN
 > -     * recommends to provide _snprintf/_vsnprintf() a buffer size that
 > -     * is one less than the actual buffer, and zero it before calling
 > -     * _snprintf/_vsnprintf() to workaround this problem.
 > -     * See http://msdn.microsoft.com/en-
 us/library/1kt27hek(v=vs.80).aspx */
 > }}}
 > Now you use them without workarounds and who knows what else...

 Well, basically all of that which you are pointing to was behing
 `_MSC_VER` which is not defined in our builds anyway. Thus, we are/were
 not affected by that. Or am I missing something?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23663#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list