[tor-bugs] #16010 [Applications/Tor Browser]: Get a working content process sandbox for Tor Browser on Windows

[Tor Bug Tracker & Wiki]

#16010: Get a working content process sandbox for Tor Browser on Windows
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-security,    |  Actual Points:
  GeorgKoppen201709, TorBrowserTeam201709R       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:63 arthuredelstein]:
 > Replying to [comment:54 gk]:
 > > `bug_16010_v4` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_16010_v4) has the `tor-browser` patches for review.
 https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_16010_v4&id=03833cf4c2a833f6e5420e92368ac2dae1b99c70
 has the additional code changes I needed to apply.
 > >
 > > Attached is a fix for the `tor-browser-build` site as well as this is
 still needed due to different `.mozconfig` handlings.
 >
 > I also had a look and didn't find any obvious errors, though I too am
 not familiar with the chromium sandbox code. I think it might be useful to
 briefly document the compile issues fixed in the first patch, either as
 comments or in the commit message.
 >
 > One thing that puzzled me is the section here:
 > https://gitweb.torproject.org/user/gk/tor-
 browser.git/diff/security/sandbox/chromium-
 shim/base/win/sdkdecls.h?h=bug_16010_v4&id=4f613829fdcbf6dba4e80e8df1d356cb1c0a7de7
 > You have changed one constant integer to the uLL suffix, but the others
 remain ui64. I'm wondering if there's a reason for that.

 There is no reason for that. It's mainly Jacek PoC he whipped up to get
 the code compiled. It certainly needs some clean-up. We have #23659 for
 that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16010#comment:68>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online