[tor-bugs] #23500 [Core Tor/Tor]: check-spaces.pl should check spaces after a comma when in functions.

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Sep 26 05:32:39 UTC 2017


#23500: check-spaces.pl should check spaces after a comma when in functions.
--------------------------+------------------------------------
 Reporter:  ewong         |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:  code-style    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:10 ewong]:
 > as it stands, the find.. command is getting difficult since I have yet
 to discover
 > a single command line which checks if the additional ','->', ' change
 will increase
 > the line length.. if so, it changes the line and then wraps the line
 near the end;
 > but that affects a bunch load of other lines.
 >
 > I'm starting to feel like just going through the list of files and
 changing
 > it manually will make it 'easier'.   might anyone have any advice?
 > thanks

 A mass replace script in one commit, then a few manual fixes in the next
 commit is fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23500#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list