[tor-bugs] #22805 [Core Tor/Tor]: Remove or_circuit_t.is_first_hop, because it's not accurate any more

[Tor Bug Tracker & Wiki]

#22805: Remove or_circuit_t.is_first_hop, because it's not accurate any more
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, security-review,     |  Actual Points:  .3
  review-group-23                                |
Parent ID:                                       |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:16 nickm]:
 > Replying to [comment:14 teor]:
 > > I think we can take out all the code that deals with CREATE_FAST,
 including the code around `cfe6b444d652464b0b6bb18b4a4a24b0cfb0da81`
 >
 > I've updated bug22805_v2 with this change.

 Let's get this merged.

 > > and just check for a non-zero identity digest.
 >
 > Hm; that's a bigger change than we'd been talking about here; I think I
 should open another ticket to change it in 0.3.3. Would that be okay with
 you?

 Sounds like a good plan.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22805#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online