[tor-bugs] #7164 [Core Tor/Tor]: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced 1 node(s); held_by_nodes == 1

[Tor Bug Tracker & Wiki]

#7164: microdesc.c:378: Bug: microdesc_free() called, but md was still referenced
1 node(s); held_by_nodes == 1
-------------------------------------------------+-------------------------
 Reporter:  jaj123                               |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.4.19
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, 025-backport, nickm-     |  Actual Points:
  should-review                                  |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review
 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


Comment:

 Branch `bug7164_032` is a rebase of the older attempted fix (possibly
 irrelevant) with the other fix suggested above.

 I don't see how clearing all the md values is necessary in
 nodelist_set_consensus() -- any microdesc value not reached in the main
 loop in that function should get removed later, by nodelist_purge().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7164#comment:95>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online